Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metric type): Use rate instead of count when submitting metric to Datadog #58

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix(metric type): Use rate instead of count when submitting metric to Datadog #58

merged 1 commit into from
Aug 10, 2023

Conversation

taonic
Copy link
Collaborator

@taonic taonic commented Aug 10, 2023

What was changed

This PR fixes the previously mistakenly chosen metric type when submitting to Datadog. Rate should be used instead of counter.

Before

image

After

image

Why?

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@taonic
fix(metric type): Use rate instead of count when submitting metric to…
8f71e70 
… Datadog

This PR fixes the previously mistakenly chosen metric type when
submitting to Datadog. Rate should be used instead of counter.
@taonic taonic requested a review from TimSimmons August 10, 2023 05:19
@taonic taonic merged commit e01d26f into main Aug 10, 2023
4 checks passed
@taonic taonic deleted the taonic/fix_DD_rate_metric_type branch August 10, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSimmons TimSimmons TimSimmons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taonic @TimSimmons